In movies decades ago, smoking cigarettes was common. Very rarely will you see a "good guy" smoking cigarettes today. But if the character is a bad guy, and even if they want to underscore that the character is some version of a socioeconomic scumbag, they'll have him or her smoke cigarettes.
I find that to be more common than using cigar smoking to indicate a bad guy. Just look at Independence day where Will Smith and Jeff Goldblum focused on smoking a cigar to symbolize victory over the bad guy aliens.
Or Kurt Russell when he played Wyatt Earp in the movie Tombstone, where Wyatt says, "I wouldn't mind one of those cigars..."
Or Liam Neeson as Hannibal Smith in The A Team. And of course Clint Eastwood in ALL his western moview.